Custom Buttons²

[SCClockDr]

Hi All

Things are a changing over in the Mozilla development world!!
What changed:

1. Firefox's toolbox ID
   1. Was - navigator-toolbox
   2. Now - browser-toolbox
   This will affect you if you reference the toolbox directly vs through the extension as custombuttons.gToolbox
2. Firefox's nav-bar ID - Where the default location bar is.
   1. Was - nav-bar
   2. Now - navigator-toolbar
3. Firefox's Bookmarks tool bar ID - Still hosts bookmarks by default.
   1. Was - PersonalToolbar
   2. Now - personal-toolbar
4. Firefox's Location bar and associated buttons are more strongly bound to the navigator-toolbar.
   1. FF2 - Easily moved about as you wished
   2. FF3 Placing the Location bar on any tool bar but the navigation-toolbar causes the styling to change and the original remains on the navigation-toolbar till Re-Start This may not be the case in future Nightly builds as the kinks get worked out.
5. For those that insist on using your own mouse click handler!
   1. The popup.showPopup method is deprecated
   2. The Nightly builds now support popup.openPopup
   3. The arguments required are also different.
6. Here is what Custom Buttons² is now using as of Version 2.0.15b12.

   Code: Select all

     gShowPopup:function ( node, menuId ) //{{{
  {
    let position = "overlap";
    if ( typeof menuId != "string") menuId = "custombuttons-contextpopup";
    var popup = document.getElementById( menuId );            // Get the menu
    document.popupNode = node;                                // Post node to document.
    if (typeof popup.openPopup == CB2const.FUNCTION) {        // Test for new popup function
      var x = node.boxObject.width*.6;                        // Set x OffSet
      var y = node.boxObject.height*.6;                       // Set y OffSet
      popup.openPopup(node, position, x, y, true, false);     // Pop up the menu
    }  // End if ( typeof popup.openPopup == CB2const.FUNCTION )
    else {                                                    // New popup function not present
      var x = node.boxObject.x + (node.boxObject.width *.6);  // Set xCoord.
      var y = node.boxObject.y + (node.boxObject.height*.6);  // Set yCoord.
      popup.showPopup(node, x, y, "popup", null, null);       // Pop up the menu
    } // End else ( typeof popup.openPopup == CB2const.FUNCTION )
  }  //}}} End Method gShowPopup( node )


   Our new method uses a different positioning algorithm than in the past in all Applications and Versions.
   1. Note the math used to calculate the offset.
   2. Also note the test for behavior is based on the openPopup method's presence == FF3 meaning you need not test further for App Version to use this method.
7. For those using Custom Buttons²'s Mouse handler no work is needed, as the extension will handle the change in 2.0.15b12 and future versions.
   
My hope is this change will result in a more consistent look and feel.